guan404ming commented on code in PR #51667:
URL: https://github.com/apache/airflow/pull/51667#discussion_r2285513364
##########
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
@@ -110,16 +113,30 @@ export const DetailsLayout = ({ children, error,
isLoading, tabs }: Props) => {
key={`${dagView}-${direction}`}
ref={panelGroupRef}
>
- <Panel defaultSize={dagView === "graph" ? 70 : 20} id="main-panel"
minSize={6} order={1}>
+ <Panel
+ defaultSize={dagView === "graph" ? 70 : 20}
+ id="main-panel"
+ minSize={showGantt && dagView === "grid" ? 60 : 20}
+ order={1}
+ >
<Box height="100%" marginInlineEnd={2} overflowY="auto"
position="relative">
<PanelButtons
dagView={dagView}
limit={limit}
panelGroupRef={panelGroupRef}
setDagView={setDagView}
setLimit={setLimit}
+ setShowGantt={setShowGantt}
+ showGantt={showGantt}
/>
- {dagView === "graph" ? <Graph /> : <Grid limit={limit} />}
+ {dagView === "graph" ? (
+ <Graph />
+ ) : (
+ <HStack gap={0}>
+ <Grid limit={limit} />
Review Comment:
Make sense and tested on large screen. Passing the condition did fix the
issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
