potiuk commented on code in PR #54449:
URL: https://github.com/apache/airflow/pull/54449#discussion_r2291331166
##########
airflow-core/src/airflow/cli/commands/triggerer_command.py:
##########
@@ -59,7 +59,10 @@ def triggerer_run(skip_serve_logs: bool, capacity: int,
triggerer_heartrate: flo
@providers_configuration_loaded
def triggerer(args):
"""Start Airflow Triggerer."""
- settings.MASK_SECRETS_IN_LOGS = True
+ from airflow.sdk._shared.secrets_masker import SecretsMasker
+
+ SecretsMasker.MASK_SECRETS_IN_LOGS = True
Review Comment:
I somehow do not like to set constants in the module this way, this feels
brittle. Is it possible to have a setter for that - a method that you can call
to change the value of this setting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
