amoghrajesh commented on PR #54449: URL: https://github.com/apache/airflow/pull/54449#issuecomment-3209403689
Right an update now: @potiuk there was a small issue with the prek hook, if the library using the shared library already has the dependencies required by the shared liibrary, it would not check for the presence and just duplicate it. For example, `airflow-core` would do this. `airflow-core` already has pendulum and the rest defined. I fixed it in the commit: [4999d9a](https://github.com/apache/airflow/pull/54449/commits/4999d9a0fd63b0b4a0693b2cab4f70fc007801a6) ``` # Start of shared timezones dependencies "pendulum>=3.1.0", # End of shared timezones dependencies # Start of shared secrets_masker dependencies "pendulum>=3.1.0", "methodtools>=0.4.7", "colorlog>=6.8.2", # End of shared secrets_masker dependencies ``` Anyways, for the duplicates like `pendulum` across "shared" libraries, like pendulum above, we could do a follow up, it would not cause errors for now, it is just redundant. With the current state, I can do this now: ``` cd shared/secrets_masker uv sync uv run pytest -x ============================================================================================================================================== short test summary info ============================================================================================================================================== XFAIL tests/secrets_masker/test_secrets_masker.py::TestSecretsMasker::test_exc_tb - Cannot filter secrets in traceback source ===================================================================================================================================== 96 passed, 1 xfailed, 2 warnings in 0.19s ===================================================================================================================================== ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
