amoghrajesh commented on code in PR #54449: URL: https://github.com/apache/airflow/pull/54449#discussion_r2290130756
########## shared/secrets_masker/pyproject.toml: ########## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[project] +name = "apache-airflow-shared-secrets_masker" Review Comment: There is a reason I did that actually. ``` Check shared distributions structure........................................Failed - hook id: check-shared-distributions-structure - exit code: 2 Checking: timezones shared project pyproject.toml exists for timezones OK project name matches timezones and is 'apache-airflow-shared-timezones' OK src/airflow_shared/timezones exists for timezones OK src/airflow_shared/__init__.py does not exist for timezones OK tests/timezones exists for timezones OK 'Private :: Do Not Upload' classifier is only classifier OK build-system is correct for timezones OK tool.hatch.build.targets.wheel is correct for timezones OK tool.ruff is correct for timezones OK tool.ruff.lint rules are correct for timezones OK Summary: timezones is OK Checking: secrets_masker shared project pyproject.toml exists for secrets_masker OK project name 'apache-airflow-shared-secrets-masker' does not match for secrets_masker or is not 'apache-airflow-shared-secrets_masker' ``` Either we could correct the precommit to allow such normalised names or keep the distro name this way. WDYT? I am fine with `_` too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
