uranusjr commented on code in PR #54816:
URL: https://github.com/apache/airflow/pull/54816#discussion_r2292810807
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -1309,7 +1308,7 @@ def get_extra_links(self, ti: TaskInstance, name: str) ->
str | None:
link = self.operator_extra_link_dict.get(name) or
self.global_operator_extra_link_dict.get(name)
if not link:
return None
- return link.get_link(self.unmap(None), ti_key=ti.key) # type:
ignore[arg-type] # TODO: GH-52141 - BaseOperatorLink.get_link expects
BaseOperator but receives SerializedBaseOperator
+ return link.get_link(self, ti_key=ti.key) # type: ignore[arg-type] #
TODO: GH-52141 - BaseOperatorLink.get_link expects BaseOperator but receives
SerializedBaseOperator
Review Comment:
Hmm, I wonder if this should be kept. Would users expect get_link to be
called against a MappedOperator? It may not have the same attributes as the
underlying operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
