kaxil commented on code in PR #54816:
URL: https://github.com/apache/airflow/pull/54816#discussion_r2296382049
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -1309,7 +1308,7 @@ def get_extra_links(self, ti: TaskInstance, name: str) ->
str | None:
link = self.operator_extra_link_dict.get(name) or
self.global_operator_extra_link_dict.get(name)
if not link:
return None
- return link.get_link(self.unmap(None), ti_key=ti.key) # type:
ignore[arg-type] # TODO: GH-52141 - BaseOperatorLink.get_link expects
BaseOperator but receives SerializedBaseOperator
+ return link.get_link(self, ti_key=ti.key) # type: ignore[arg-type] #
TODO: GH-52141 - BaseOperatorLink.get_link expects BaseOperator but receives
SerializedBaseOperator
Review Comment:
@uranusjr https://github.com/apache/airflow/pull/46613 is released in 3.0.0
and https://github.com/apache/airflow/pull/50238 in 3.0.1
>get_link used to only accept BaseOperator before this change
How would that work with `CustomOperators` though! We don't serialize all
attributes so `extra_links` with `operator` as argument will have limited
attributes to work with for global op links
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
