uranusjr commented on code in PR #54816:
URL: https://github.com/apache/airflow/pull/54816#discussion_r2296375668
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -1309,7 +1308,7 @@ def get_extra_links(self, ti: TaskInstance, name: str) ->
str | None:
link = self.operator_extra_link_dict.get(name) or
self.global_operator_extra_link_dict.get(name)
if not link:
return None
- return link.get_link(self.unmap(None), ti_key=ti.key) # type:
ignore[arg-type] # TODO: GH-52141 - BaseOperatorLink.get_link expects
BaseOperator but receives SerializedBaseOperator
+ return link.get_link(self, ti_key=ti.key) # type: ignore[arg-type] #
TODO: GH-52141 - BaseOperatorLink.get_link expects BaseOperator but receives
SerializedBaseOperator
Review Comment:
Actually I think this was from a series of incorrect changes… get_link used
to only accept BaseOperator before this change
https://github.com/apache/airflow/pull/46613/
You can see `get_extra_links` always calls `unmap` to get a BaseOperator.
After the PR above, `get_extra_links` was then incorrectly “restored” to
pass in MappedOperator in #50238. This PR has not been a release yet.
I think removing `unmap` here is therefore wrong. It should be kept for
`get_extra_links` for compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
