Lee-W commented on code in PR #54903:
URL: https://github.com/apache/airflow/pull/54903#discussion_r2306331062
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -379,14 +379,15 @@ def filter_param_factory(
default_factory: Callable[[], T | None] | None = None,
skip_none: bool = True,
transform_callable: Callable[[T | None], Any] | None = None,
+ description: str | None = None,
Review Comment:
```suggestion
*,
description: str | None = None,
```
We probably should have made it keyword-only long ago. but not a bad idea to
start from new arguments
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -379,14 +379,15 @@ def filter_param_factory(
default_factory: Callable[[], T | None] | None = None,
skip_none: bool = True,
transform_callable: Callable[[T | None], Any] | None = None,
+ description: str | None = None,
) -> Callable[[T | None], FilterParam[T | None]]:
# if filter_name is not provided, use the attribute name as the default
filter_name = filter_name or attribute.name
# can only set either default_value or default_factory
query = (
- Query(alias=filter_name, default_factory=default_factory)
+ Query(alias=filter_name, default_factory=default_factory,
description=description)
Review Comment:
yep, i'd like it to keep as it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
