potiuk commented on code in PR #54072:
URL: https://github.com/apache/airflow/pull/54072#discussion_r2318028328
##########
.github/workflows/additional-prod-image-tests.yml:
##########
@@ -188,3 +188,13 @@ jobs:
id: breeze
- name: "Run Task SDK integration tests"
run: breeze testing task-sdk-integration-tests
+
+ test-e2e-integration-tests:
+ name: "Test e2e integration tests with PROD image"
+ uses: ./.github/workflows/airflow-e2e-tests.yml
+ with:
+ runners: ${{ inputs.runners }}
+ platform: ${{ inputs.platform }}
+ default-python-version: "${{ inputs.default-python-version }}"
+ use-uv: ${{ inputs.use-uv }}
+ docker-image-tag: "ghcr.io/apache/airflow/main/prod/python${{
inputs.default-python-version }}:latest"
Review Comment:
Not sure about this parameter. So far we were "hiding" the ghcr.io prefix
in `breeze` and I am not sure if there is a point to pass it here and hard-code
like that.
Maybe a better way would be to add an output in "Prepare breeze & PROD
image" and use it as input in the "airlfow-e2e-tests" ?
This composite action already produced an output we use:
```yaml
outputs:
host-python-version:
description: Python version used in host
value: ${{ steps.breeze.outputs.host-python-version }}
```
It could also produce image-name as an ouput there. That would be much more
"contained" place where we hard-code the image name,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
