potiuk commented on code in PR #54072: URL: https://github.com/apache/airflow/pull/54072#discussion_r2318040802
########## airflow-e2e-tests/tests/airflow_e2e_tests/e2e_test_utils/clients.py: ########## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import time +from datetime import datetime, timezone +from functools import cached_property + +import requests +from requests.adapters import HTTPAdapter +from urllib3.util.retry import Retry + +from airflow_e2e_tests.constants import ( + AIRFLOW_WWW_USER_PASSWORD, + AIRFLOW_WWW_USER_USERNAME, + DOCKER_COMPOSE_HOST_PORT, +) + + +class AirflowClient: Review Comment: Question: Should we maybe build and use our `python client` here rather than hard-code HTTP requests? I think we could make it somehow an automatically build dependency of our tests. This would have additional benefit because those tests would ALSO test our client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
