ephraimbuddy commented on code in PR #54505:
URL: https://github.com/apache/airflow/pull/54505#discussion_r2354872180
##########
airflow-core/tests/unit/serialization/test_serialized_objects.py:
##########
@@ -416,7 +415,7 @@ def __len__(self) -> int:
equal_exception,
),
(
- AirflowFailException("uuups, failed :-("),
+ AirflowException("uuups, failed :-("),
Review Comment:
Had to revert the change on this. AirflowFailException is now raised by SDK
and when I duplicated it to inherit from AirflowException, this particular test
started passing. However, there are other imports of AirflowFailException from
providers that started failing. They were failing because SDK raises a
different AirflowFailException but we are catching a different one from airflow
core. I think AirflowException here is a better option. Moreover, serialization
raises AirflowException and not AirflowFailException. The test was passing
before because AIrflowFailException inherited the AirflowException raised by
serialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
