ferruzzi commented on code in PR #56150:
URL: https://github.com/apache/airflow/pull/56150#discussion_r2397525156
##########
airflow-core/src/airflow/utils/otel_config.py:
##########
@@ -68,27 +68,26 @@ class OtelConfig:
def __post_init__(self):
"""Validate the environment variables where necessary."""
- endpoint_type_specific =
f"OTEL_EXPORTER_OTLP_{self.data_type.name.upper()}_ENDPOINT"
+ endpoint_type_specific =
f"OTEL_EXPORTER_OTLP_{self.data_type.name}_ENDPOINT"
if not self.endpoint:
raise ValueError(
f"Missing required environment variable:
'OTEL_EXPORTER_OTLP_ENDPOINT' or {endpoint_type_specific}"
)
- stripped_protocol = (self.protocol or
"").strip().strip('"').strip("'").lower()
- if stripped_protocol not in ("grpc", "http/protobuf"):
Review Comment:
I think you'd still need to invert this to check if either of the substrings
are in self.protocol, right? Or were the strip statements before not needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
