potiuk commented on PR #55917: URL: https://github.com/apache/airflow/pull/55917#issuecomment-3364970945
Few comments: This PR is a bit too complex and makes (IMHO) the usability of copilot translation a bit less than the one embedded in IDEs / with interactivity. I am not sure if we want to do it - this might - paradoxically - make the translations less good because people will be too "lazy" to review them and it will not be as easy to review as with interactive copilot sessions. I think the biggest value of the IDE-driven translation is the UI/UX where you see together the original (with TODO) and translation and you can individually approve blocks of translation or even modify them directly in the editor. This is why running "please translate all todo: phrases" in IntelliJ or VSCode integrated copilot is so nice, because you get HITL (Human-In-The-Loop) where you can review and look at the translations individually after they are done. This automated translation here has the drawback, that when you run automated translation like that and even try to review it in the commit, you do not see original English text. This is what you see when you do translations in IntelliJ's copilot: <img width="1427" height="1140" alt="Screenshot 2025-10-03 at 02 24 52" src="https://github.com/user-attachments/assets/4e1f7cc0-a366-45ac-b11c-662661b8d11a"; /> I can individually review before/after as well as even manually modify the translations. And it's really good UX. I think there is a case where we want to translate "all languages" - when we want to open single PR for all translators (I tried it before the release) - but I think this should be reserved only for "all languages" not for single language (there interactive approach is way better). And even if we want to do it automatically - all the token/etc. is not needed. Recently GitHub released "copilot" cli, I tested it and it works very well. In interactive mode it can even provide similar green/red display in the terminal (without capability of correcting it manually yet - but this is likely something they will add). It's just enough to start copilot CLI with subprocess and it will do all the gh token handling thing. ``` copilot --allow-all-tools --add-dir . -p 'Please translate the remaining "TODO: translate" in airflow-core/src/airflow/ui/public/i18n/locales/pl/' ``` Also there is no need to split json and do individual translations, it's way faster and better (more relevant context) if you pass the whole file and ask AI to translate alll TODO: entries in it. It does not even have to work on individual strings, AI is capable of finding the right strings on its own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
