kaxil commented on code in PR #56202:
URL: https://github.com/apache/airflow/pull/56202#discussion_r2388295581
##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -945,9 +945,12 @@ def next_retry_datetime(self):
For exponential backoff, retry_delay is used as base and will be
converted to seconds.
"""
- from airflow.sdk.definitions._internal.abstractoperator import
MAX_RETRY_DELAY
+ from airflow.sdk.definitions._internal.abstractoperator import
DEFAULT_RETRY_DELAY, MAX_RETRY_DELAY
delay = self.task.retry_delay
+ if delay is None:
+ # If retry_delay is None, use the default delay
+ delay = DEFAULT_RETRY_DELAY
Review Comment:
The issue I think is 3.0.6 excludes the defaults in serialized dags, which
means if you check your serialized dag JSON for that specific dag, it won't
have `retry_delay` (I assume), and when you upgraded to 3.1.0 -- because it
didn't have anything and there is no default in 3.1.0 -- it returns None.
If you pasted the serialized dag JSON, that would confirm it -- I am pretty
confident that is the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
