anshuksi282-ksolves opened a new pull request, #56422:
URL: https://github.com/apache/airflow/pull/56422
Issue: #56306
FIX: Prevent AttributeError when updating SerializedDagModel for dynamic DAGs
This PR fixes a stability issue in `SerializedDagModel.write_dag` by adding
a null check before updating an existing record for dynamic DAGs.
### Context and Problem
In the section of `write_dag` dedicated to updating dynamic DAGs (i.e., when
`dag_version` exists but has no task instances), the code retrieves the latest
`SerializedDagModel` instance using `cls.get(dag.dag_id, session=session)`.
If `cls.get(dag.dag_id, session=session)` returns `None` (for example, due
to a race condition where the record was just deleted or not found in the
current session), the subsequent code attempts to modify attributes:
`latest_ser_dag._data = new_serialized_dag._data`
This would raise an `AttributeError` because `latest_ser_dag` is `None`.
### Solution
- Added a null check to ensure that `latest_ser_dag` exists before updating
its attributes.
- This prevents `AttributeError` and improves the stability of DAG
serialization for dynamic DAGs.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership.
The ASF licenses this file under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests.
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
