anshuksi282-ksolves commented on code in PR #56422:
URL: https://github.com/apache/airflow/pull/56422#discussion_r2435186865


##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -412,7 +412,7 @@ def write_dag(
         serialized_dag_hash = session.scalars(
             select(cls.dag_hash).where(cls.dag_id == 
dag.dag_id).order_by(cls.created_at.desc())
         ).first()
-        dag_version = DagVersion.get_latest_version(dag.dag_id, 
session=session)
+        dag_version = DagVersion.get_latest_version(dag.dag_id, 
session=session, load_dag_model=True)

Review Comment:
   Yes, exactly — that’s why I introduced a separate argument 
`load_serialized_dag`. This way, `load_dag_model `continues to only load the 
`DagModel`, and we can explicitly load `SerializedDagModel` when needed without 
affecting other places where `load_dag_model `is used. This avoids accidentally 
eager-loading the serialized DAG in places where it’s not required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to