Zinkue commented on PR #56854:
URL: https://github.com/apache/airflow/pull/56854#issuecomment-3419755844

   It generates a custom color palette where:
   - Luminosity comes from a list, e.g. output luminosity does not depend of 
input color
   - Chroma is generated from to input color's chroma
   - Hue is constant based in input color
   
   Some doubts I have:
   1. I used [culori](https://github.com/Evercoder/culori) for color 
transformation. I can do the same with 
[colorjs.io](https://github.com/color-js/color.js) On which criteria you select 
one or another (Github stars, npm downloads, etc.)?
   2. From UX (see yellow output in PR description above) does the output theme 
looks fine? I tried taking into account also imputed luminosity but maybe I am 
overthinking
   
   For the future, when #55789 is merged we can add support for predefined 
themes and custom themes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to