kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348509289
########## File path: airflow/models/dag.py ########## @@ -55,9 +55,6 @@ from airflow.utils.sqlalchemy import Interval, UtcDateTime from airflow.utils.state import State -if TYPE_CHECKING: Review comment: hmm. I like the change but was also happy with the `TYPE_CHECKING` check as we don't need to import those modules otherwise at runtime. The can add unnecessary delays! From https://docs.python.org/3/library/typing.html#typing.TYPE_CHECKING: >A special constant that is assumed to be True by 3rd party static type checkers. It is False at runtime. Usage: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
