kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348494836
########## File path: airflow/models/baseoperator.py ########## @@ -26,19 +26,18 @@ import warnings from abc import ABCMeta, abstractmethod from datetime import datetime, timedelta -from typing import Any, Callable, Dict, FrozenSet, Iterable, List, Optional, Set, Type, Union +from typing import Any, Callable, Dict, FrozenSet, Iterable, List, Optional, Set, Tuple, Type, Union import jinja2 from cached_property import cached_property from dateutil.relativedelta import relativedelta -from airflow import settings from airflow.configuration import conf from airflow.exceptions import AirflowException, DuplicateTaskIdFound from airflow.lineage import DataSet, apply_lineage, prepare_lineage -from airflow.models.dag import DAG from airflow.models.pool import Pool -from airflow.models.taskinstance import TaskInstance, clear_task_instances +# noinspection PyPep8Naming +from airflow.models.taskinstance import TaskInstance as TI, clear_task_instances Review comment: Do we need to do this? We don't have any conflicting imports with the same name so I think keeping it as it is should be fine, no ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
