kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic
imports and pylint disables
URL: https://github.com/apache/airflow/pull/6601#discussion_r348503407
##########
File path: airflow/models/baseoperator.py
##########
@@ -433,8 +431,7 @@ def __init__(
self._outlets.update(outlets)
def __eq__(self, other):
- if (type(self) == type(other) and # pylint:
disable=unidiomatic-typecheck
- self.task_id == other.task_id):
+ if type(self) is type(other) and self.task_id == other.task_id:
Review comment:
I think this changes the behavior:
>The **_==_** operator compares the values of both the operands and checks
for value equality. Whereas **_is_** operator checks whether both the operands
refer to the same object or not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
