ashb commented on code in PR #57744: URL: https://github.com/apache/airflow/pull/57744#discussion_r2537345821
########## airflow-core/src/airflow/exceptions.py: ########## @@ -26,6 +26,9 @@ from http import HTTPStatus from typing import TYPE_CHECKING, Any, NamedTuple +# Import from shared library for backward compatibility +from airflow._shared.configuration.exceptions import AirflowConfigException as _AirflowConfigException Review Comment: ```suggestion from airflow._shared.configuration.exceptions import AirflowConfigException as AirflowConfigException ``` And then you don't need the extra sublcass. The `X as X` is an accepted way to say "we are re-exporting" this class, and ruff/typecheckers etc won't complain about unnecessary import either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
