ashb commented on code in PR #57744:
URL: https://github.com/apache/airflow/pull/57744#discussion_r2537356151
##########
airflow-core/src/airflow/configuration.py:
##########
@@ -263,6 +234,41 @@ def _lookup_sequence(self) -> list[Callable]:
self._get_option_from_provider_fallbacks,
]
+ def _get_config_sources_for_as_dict(self) -> list[tuple[str,
ConfigParser]]:
+ """Override the base method to add provider fallbacks."""
+ return [
+ ("provider-fallback-defaults",
self._provider_config_fallback_default_values),
+ ("default", self._default_values),
+ ("airflow.cfg", self),
+ ]
+
+ def _raise_config_exception(self, message: str) -> None:
+ """
+ Override to raise core's AirflowConfigException instead of shared one.
+
+ This ensures that exceptions raised by shared parser methods are
catchable
+ by exception handlers that users would catch for conf usually.
+ """
+ from airflow.exceptions import AirflowConfigException as
CoreAirflowConfigException
+
+ raise CoreAirflowConfigException(message)
+
Review Comment:
```suggestion
```
Given exceptions already re-exported this I don't think we need this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
