potiuk commented on PR #58578:
URL: https://github.com/apache/airflow/pull/58578#issuecomment-3567022715

   > May I ask what's the difference between them?
   
   @jason810496 
   
   I think there is a big difference and they are pretty "parallel" -> in 
#58578  it's just "one" check that is turned into a breeze command. What 
@amoghrajesh is doing here is more trying to execute the checks in a one single 
command for one case (for now) as an alternative way of doing things - it also 
removes the more "manual" checks where you essentially copy&paste a bash 
command to run the check.
   
   I think the difference is more "philosohical" and likely we could even have 
those in parallel - and I even see a value in having those checks done in two 
ways by different people.
   
   There is always a risk that one of those things will "over-automate" things 
(like over-fitting in AI machine learning)  - simply it will be showing "OK" 
where there will be some undetected problems, missed by automation.
   
   I can very easily imagine that the proposal of @amoghrajesh might be good 
for some "casual" PMC members who want to verify things and trust completely 
the code of breeze doing all the verifications. 
   
   But also I can imagine some release managers who are relesing other 
artifacts as well will want to do a bit more "manual" check with stopping after 
every step and looking at the intermediate artifacts more manually. This might 
also give them more  understanding of what's going on under-the-hood.
   
   So - if I might propose - having the more "manual" step-by-step check AND 
having the "complete check" as a single operation - might make perfect sense.
   
   
   So ... maybe BOTH PRs are similar-but-different and are worth merging :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to