potiuk commented on code in PR #58578: URL: https://github.com/apache/airflow/pull/58578#discussion_r2554163670
########## dev/breeze/src/airflow_breeze/commands/release_management_validation.py: ########## @@ -0,0 +1,115 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: One small thing. For now we had assumption (which was not 100% kept that we have one "command.py" and one "command_config.py" for each command group - obviously some of the big commands grew out of it (release_candidate), I think it wold be worth-while to rethink it and maybe do it differently - or maybe clean-up the relase_management.py and bring all the commands back to it ? The initial idea was that in most cases, the _command.py will only have the commands + some initial validations, but that the "meat" of the commmand will go to utils - where we could unit test it as well for some more complex commands. Maybe (And this could be a follow-up and I can do it if that sounds goood) we could refactor it this way (including release_candidate). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
