ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid 
unnecessary sleep to maintain local task job heart rate
URL: https://github.com/apache/airflow/pull/6553#discussion_r351004248
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -1320,9 +1320,9 @@ def set_duration(self):
 
     def xcom_push(
             self,
-            key,
-            value,
-            execution_date=None):
+            key: str,
+            value: Any,
+            execution_date: Optional[datetime] = None) -> None:
 
 Review comment:
   Are these changes required to make this PR pass tests? If not it is 
preferred to not change files that you don't have to for the subject of the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to