Lee-W commented on code in PR #56760:
URL: https://github.com/apache/airflow/pull/56760#discussion_r2563774431
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -72,21 +75,31 @@ def _get_task_instance_with_hitl_detail(
task_id: str,
session: SessionDep,
map_index: int,
-) -> TI:
- query = (
- select(TI)
- .where(
- TI.dag_id == dag_id,
- TI.run_id == dag_run_id,
- TI.task_id == task_id,
+ try_number: int | None = None,
+) -> TI | TIH:
+ def _query(orm_object: Base) -> TI | TIH | None:
+ query = (
+ select(orm_object)
+ .where(
+ orm_object.dag_id == dag_id,
+ orm_object.run_id == dag_run_id,
+ orm_object.task_id == task_id,
+ orm_object.map_index == map_index,
+ )
+ .options(joinedload(orm_object.hitl_detail))
)
- .options(joinedload(TI.hitl_detail))
- )
- if map_index is not None:
- query = query.where(TI.map_index == map_index)
+ if try_number is not None:
+ query = query.where(orm_object.try_number == try_number)
+
+ task_instance = session.scalar(query)
Review Comment:
This pattern is also used here
https://github.com/apache/airflow/blob/1aa9b7af38b52afa79d5108a04ceb5fd181682ba/airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py#L666-L680
This is TI or TIH. both of them are technically task instance. We could
renamed it as `ti_or_tih` but I don't think that's better 🤔
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -190,10 +203,37 @@ def get_hitl_detail(
task_id=task_id,
session=session,
map_index=map_index,
+ try_number=None,
)
return task_instance.hitl_detail
+@task_instances_hitl_router.get(
+ task_instance_hitl_path + "/tries/{try_number}",
+ status_code=status.HTTP_200_OK,
+ responses=create_openapi_http_exception_doc([status.HTTP_404_NOT_FOUND]),
+ dependencies=[Depends(requires_access_dag(method="GET",
access_entity=DagAccessEntity.HITL_DETAIL))],
+)
+def get_hitl_detail_try(
Review Comment:
then it probably should be `get_hitl_detail_try_details` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
