pierrejeambrun commented on code in PR #56760:
URL: https://github.com/apache/airflow/pull/56760#discussion_r2577679017
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -190,10 +203,37 @@ def get_hitl_detail(
task_id=task_id,
session=session,
map_index=map_index,
+ try_number=None,
)
return task_instance.hitl_detail
+@task_instances_hitl_router.get(
+ task_instance_hitl_path + "/tries/{try_number}",
+ status_code=status.HTTP_200_OK,
+ responses=create_openapi_http_exception_doc([status.HTTP_404_NOT_FOUND]),
+ dependencies=[Depends(requires_access_dag(method="GET",
access_entity=DagAccessEntity.HITL_DETAIL))],
+)
+def get_hitl_detail_try(
Review Comment:
Double `detail` in the name is confusing. I get why it's there though.
Also I think in the current impl, you missed the trailing `s`
`get_hitl_detail_try_detail`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
