jason810496 commented on code in PR #56187:
URL: https://github.com/apache/airflow/pull/56187#discussion_r2575435614
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -419,11 +418,9 @@ def fail(self, key: TaskInstanceKey, info=None) -> None:
"""
trace_id = Trace.get_current_span().get_span_context().trace_id
if trace_id != NO_TRACE_ID:
- span_id = int(gen_span_id_from_ti_key(key, as_int=True))
- with DebugTrace.start_span(
+ with DebugTrace.start_child_span(
Review Comment:
Are we intend to replace `start_span` with `start_child_span` in this PR? Or
should we separate them as another PR?
##########
shared/observability/src/airflow_shared/observability/traces/otel_tracer.py:
##########
@@ -256,7 +260,7 @@ def _new_span(
tracer = self.get_tracer(component=component)
if start_time is None:
- start_time = timezone.utcnow()
+ start_time = datetime.datetime.now(tz=pendulum.UTC)
Review Comment:
If `pendulum` is compatible, would it be better to use `pendulum` instead of
`datetime` here?
```suggestion
pendulum.now(tz=pendulum.UTC)
```
If yes, then we could also remove the top level import of `datetime`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
