amoghrajesh commented on code in PR #58825:
URL: https://github.com/apache/airflow/pull/58825#discussion_r2575677939
##########
shared/import_utils/src/airflow_shared/import_utils/module_loading.py:
##########
@@ -67,3 +67,25 @@ def qualname(o: object | Callable) -> str:
def iter_namespace(ns: ModuleType):
return pkgutil.iter_modules(ns.__path__, ns.__name__ + ".")
+
+
+def is_valid_dotpath(path: str) -> bool:
Review Comment:
My main concern around having too many shared libraries is _confusion_. It
is very easy even for people using IDE support to end up importing
`airflow._shared` in sdk code. Created unwanted and avoidable coupling.
There is also another risk (not specific to this case), lets take example of
exceptions. If those are shared, `except MyException` would not catch sometimes
just because the code that threw it was in `airflow.sdk._shared` but catching
code is in `airflow._shared`.
To be clear, I do not have big objection, but thats my thinking in limiting
shared libraries _only_ to whats really needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
