potiuk commented on code in PR #58825:
URL: https://github.com/apache/airflow/pull/58825#discussion_r2582230231
##########
shared/module_loading/src/airflow_shared/module_loading/__init__.py:
##########
@@ -14,21 +15,24 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
from __future__ import annotations
+import pkgutil
from collections.abc import Callable
from importlib import import_module
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+ from types import ModuleType
def import_string(dotted_path: str):
"""
Import a dotted module path and return the attribute/class designated by
the last name in the path.
- Note: Only supports top-level attributes or classes.
-
Raise ImportError if the import failed.
"""
+ # TODO: Add support for nested classes. Currently, it only works for
top-level classes.
Review Comment:
Nope. I just copied it from the original code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
