potiuk commented on PR #58825: URL: https://github.com/apache/airflow/pull/58825#issuecomment-3598910129
@amoghrajesh @xBis7 I rebased my change and added some changes: * the "import_utils.module_loading" module is no longer "import_utils" - it's just `module_loading` - I modified the code quite a bit to move the shared methods to `__int__.py` rather than have a "import_utls.module_loading` - i think that can largely alleviate those concerns @amoghrajesh had about too many "utils" - I think it's really nice one and simpler than before. * I also realised we need one more check (and turned out we have quite a bit of work to do still). The `devel-common` module needs a bit of polish, refactor - and I think we will have to add all the`_shared` modules as dependencies to it. Simply `devel_common` should NEVER import anything from `airflow.` nor `airflow.sdk` - because it can be use in either of the two (and other disstributions) - so it should import everything from `airflow_shared.*` and have those packages it imports from as dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
