xBis7 commented on code in PR #56187:
URL: https://github.com/apache/airflow/pull/56187#discussion_r2575701603
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -419,11 +418,9 @@ def fail(self, key: TaskInstanceKey, info=None) -> None:
"""
trace_id = Trace.get_current_span().get_span_context().trace_id
if trace_id != NO_TRACE_ID:
- span_id = int(gen_span_id_from_ti_key(key, as_int=True))
- with DebugTrace.start_span(
+ with DebugTrace.start_child_span(
Review Comment:
Typically, if you don't provide a parent context as a param to
`start_child_span` then it uses the current static context and it acts just
like `start_span`. It should be doable without issues.
`start_span` is also used as a function decorator and changing it globally
is extensive. The diffs for the current patch are quite large as they are. I'm
up for doing it in the future in a new PR. There are a few other tasks coming
from the above discussions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
