potiuk commented on code in PR #56187:
URL: https://github.com/apache/airflow/pull/56187#discussion_r2584286104
##########
shared/observability/src/airflow_shared/observability/traces/otel_tracer.py:
##########
@@ -256,7 +260,7 @@ def _new_span(
tracer = self.get_tracer(component=component)
if start_time is None:
- start_time = timezone.utcnow()
+ start_time = datetime.datetime.now(tz=pendulum.UTC)
Review Comment:
well - there is still pendulum.UTC used here so you have not got rid of
pendulum yet. We are generally depending a lot on pendulum anyway now, so I
guess we should leave it here as dependency - we had some plans to get rid of
it, especially that in modern python versions (3.10) the datetime support and
timezone support is generally fixed, but it would be breaking change if we get
rid of pendulum in core airflow and task-sdk especially. This will be a
separate effort, so I suggest we leave pendulum here and in pyproject.toml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
