potiuk commented on code in PR #59139: URL: https://github.com/apache/airflow/pull/59139#discussion_r2602811713
########## airflow-core/src/airflow/jobs/triggerer_job_runner.py: ########## @@ -38,6 +38,7 @@ from sqlalchemy import func, select from structlog.contextvars import bind_contextvars as bind_log_contextvars +from airflow._shared.module_loading import import_string Review Comment: They do - but I don't think they should, when you can remove it today. The choice I see is: * we can use `airflow._shared` here that is there in `airflow-core` already (as of this PR) and we can use it directly and we are not going to remove it * or we can use `airflow.sdk._shared` here that is **currently** here but we are going to remove it in the future I don't see a particular reason to use something that we are going to remove, if we can use something that we know is going to stay :). Or am I wrong somehow ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
