potiuk commented on code in PR #59139: URL: https://github.com/apache/airflow/pull/59139#discussion_r2599977654
########## airflow-core/src/airflow/dag_processing/bundles/manager.py: ########## @@ -23,13 +23,13 @@ from pydantic import BaseModel, ValidationError from sqlalchemy import delete, select +from airflow._shared.module_loading import import_string Review Comment: No - not rally - dag processing is part of the core. We are not going to even have (eventually) `airflow-task-sdk` installed in DagFileProcessor. This also means that eventually dag-processor should be separated out from "airflow-core", because dag-processor will need task-sdk, but scheduler and api-server won't. ########## airflow-core/src/airflow/dag_processing/bundles/manager.py: ########## @@ -23,13 +23,13 @@ from pydantic import BaseModel, ValidationError from sqlalchemy import delete, select +from airflow._shared.module_loading import import_string Review Comment: No - not really - dag processing is part of the core. We are not going to even have (eventually) `airflow-task-sdk` installed in DagFileProcessor. This also means that eventually dag-processor should be separated out from "airflow-core", because dag-processor will need task-sdk, but scheduler and api-server won't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
