potiuk commented on code in PR #59139: URL: https://github.com/apache/airflow/pull/59139#discussion_r2599988000
########## airflow-core/src/airflow/jobs/triggerer_job_runner.py: ########## @@ -38,6 +38,7 @@ from sqlalchemy import func, select from structlog.contextvars import bind_contextvars as bind_log_contextvars +from airflow._shared.module_loading import import_string Review Comment: Same as above - triggerer will eventually **also** have to be separated from `airflow-core` because triggers will have to import task-sdk (I guess). But neither scheduler nor api-server needs task-sdk and it should not be installed at all for anything in the code of dag-file processor or triggerer. The only imports to task-sdk should only pass by Dags parsed inside the DagFileProcessor and serialized triggers, but neither DagFileProcessor nor Triggerer should need task.sdk for anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
