stephen-bracken commented on code in PR #53368:
URL: https://github.com/apache/airflow/pull/53368#discussion_r2618779389
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/job.py:
##########
Review Comment:
I've changed the default value to 1 to reduce confusion
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/job.py:
##########
@@ -459,8 +450,9 @@ def get_pods(
label_selector = self._build_find_pod_label_selector(context,
exclude_checked=exclude_checked)
pod_list: Sequence[k8s.V1Pod] = []
retry_number: int = 0
+ parallelism = self.parallelism or 1 # Default to using single pod
parallelism
- while len(pod_list) != self.parallelism or retry_number <=
self.discover_pods_retry_number:
+ while len(pod_list) != parallelism or retry_number <=
self.discover_pods_retry_number:
Review Comment:
I've fixed the loop invariant by splitting out the break condition here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
