stephen-bracken commented on code in PR #53368:
URL: https://github.com/apache/airflow/pull/53368#discussion_r2626369806
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/job.py:
##########
@@ -461,7 +452,9 @@ def get_pods(
pod_list: Sequence[k8s.V1Pod] = []
retry_number: int = 0
- while len(pod_list) != self.parallelism or retry_number <=
self.discover_pods_retry_number:
+ while retry_number <= self.discover_pods_retry_number:
Review Comment:
Hi @rachtree, good question. I think this sounds reasonable but is outside
of the scope of this PR. My suggestion is that there should be a timeout on
`get_pods()` that is similar to the timeout in the `KubernetesPodOperator` for
pods not being ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
