Re: [PR] Add UI E2E test for DAGs list display [airflow]

[via GitHub]

vatsrahul1001 commented on PR #59374:
URL: https://github.com/apache/airflow/pull/59374#issuecomment-3681037390

   > > @chen0427ok, static checks are failing.
   > > Also, I tried running the test locally from my local and noticed for 
some of test login is failing with 429(Too many request) <img alt="image" 
width="2000" height="1202" 
src="https://private-user-images.githubusercontent.com/43964496/528937226-3ce5ca83-1b0f-4490-95fd-2e65e15dc355.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjYzMzg4NzIsIm5iZiI6MTc2NjMzODU3MiwicGF0aCI6Ii80Mzk2NDQ5Ni81Mjg5MzcyMjYtM2NlNWNhODMtMWIwZi00NDkwLTk1ZmQtMmU2NWUxNWRjMzU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjIxVDE3MzYxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRlNmM1MWY4Mzc5M2JkNzQzMGVlNTNmY2FjYWU0NTM5Yjk1ZDkzNDJhYjhhNTg1ZjA4YmMwNjVlY2Q0NjM0NDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fI28qpKHg8B0FqnXCj5YXIBLj2GX5Mt-3FB-OKJMqwA";>
   > > As all test running in parallel and doing login we are facing this 
issue. Did you not noticed this why running entire test suite
   > 
   > Hi @vatsrahul1001,
   > 
   > Apologies for the delayed response - I was caught up with other tasks and 
didn't see your message immediately.
   > 
   > ## Static Checks
   > Good news! The static checks are now passing. The [latest CI 
run](https://github.com/apache/airflow/actions/runs/20407141819) shows all 
checks completed successfully:
   > 
   > * Static checks: basic checks only
   > * CI image checks / Static checks
   > * Compile / format / lint UI
   > 
   > The previous failures were related to the `data-testid` approach. After 
switching to href-based selectors, all linting and type checking issues have 
been resolved.
   > 
   > ## 429 Rate Limit Issue - My Apologies
   > You're absolutely right, and I apologize for not raising this issue 
proactively. I did encounter the 429 "Too Many Requests" error when running the 
entire test suite locally, but it was intermittent (flaky) - sometimes tests 
would pass, sometimes they'd fail with 429. Because of this inconsistency, I 
didn't realize it was a systematic issue and failed to report it. I should have 
been more thorough.
   > 
   > Thank you for creating PR #59692 to address this! I can see you've 
implemented **Shared Authentication State** using Playwright's storage state, 
which is exactly the approach I was thinking would be ideal:
   > 
   > * Login once in global setup
   > * Save auth state
   > * Reuse across all tests
   > 
   > This will solve the problem systematically for all E2E tests, not just 
mine.
   > 
   > ## Next Steps
   > Once PR #59692 is merged, should I:
   > 
   > 1. Rebase my PR on top of it?
   > 2. Or will my tests automatically benefit from the shared auth state 
without changes?
   > 
   > Please let me know if there's anything else I need to adjust in this PR. 
Again, apologies for not catching and reporting the 429 issue earlier!
   > 
   > Best regards
   
   @chen0427ok PR #59692 is merged now you should rebase and resolve conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org