choo121600 commented on code in PR #59374:
URL: https://github.com/apache/airflow/pull/59374#discussion_r2629981338
##########
airflow-core/src/airflow/ui/tests/e2e/pages/LoginPage.ts:
##########
@@ -67,7 +67,7 @@ export class LoginPage extends BasePage {
return !urlString.includes("/login");
},
- { timeout: 15_000 },
+ { timeout: 60_000 },
Review Comment:
Do we really need this much timeout?
##########
airflow-core/src/airflow/ui/tests/e2e/pages/LoginPage.ts:
##########
@@ -84,6 +84,9 @@ export class LoginPage extends BasePage {
await this.maximizeBrowser();
await this.navigateTo(LoginPage.loginUrl);
+
+ // Wait for login form to be fully loaded (especially important for first
test run)
+ await this.usernameInput.waitFor({ state: "visible", timeout: 120_000 });
Review Comment:
I don’t think we need such a long timeout. It was enugh before.
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts:
##########
@@ -98,3 +99,299 @@ test.describe("Dag Trigger Workflow", () => {
}
});
});
+
+/**
+ * DAGS-001: Verify Dags List Displays
Review Comment:
```suggestion
* Verify Dags List Displays
```
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts:
##########
@@ -98,3 +99,299 @@ test.describe("Dag Trigger Workflow", () => {
}
});
});
+
+/**
+ * DAGS-001: Verify Dags List Displays
Review Comment:
It seems we don’t need to include the issue task number as a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
