chen0427ok commented on PR #59374: URL: https://github.com/apache/airflow/pull/59374#issuecomment-3667314502
> @chen0427ok I think we are missing some of testable items in the [issue](https://github.com/apache/airflow/issues/59307) > > **What to test** > > 1. Verify the Dag list correct with card and table view both > 2. Verify example DAGs are visible (e.g., example_bash_operator) > 3. Verify Searching of DAGs, filtering of status as per different statuses > 4. Verify sort Thank you for the feedback! I've addressed both items: ## 1. Rebased and Resolved Conflicts Successfully rebased onto \`upstream/main\` and resolved all conflicts: - Merged upstream's pagination tests and \"DAG\" → \"Dag\" naming changes - Updated all test code to use consistent \"Dag\" naming - All conflicts in \`DagsPage.ts\` and \`dags-list.spec.ts\` resolved ## 2. Added All Missing Test Items from Issue #59307 Implemented **all 4 missing test functionalities**: ### Card/Table View Toggle (\`Dags View Toggle\`) - Verifies switching between card and table view - Validates both views display correctly ### DAG Search (\`Dags Search\`) - Tests search functionality with test DAG name - Verifies filtered results are correct - Confirms clearing search restores full list ### Status Filtering (\`Dags Status Filtering\`) - Tests filtering by different statuses (success, failed, running, queued) - Validates filter buttons are visible and functional ### Sorting (\`Dags Sorting\`) - Verifies sort select is visible in card view - Tests sort dropdown opens with available options ## Code Quality All changes follow contribution guidelines: - Page Object Model pattern - \`data-testid\` selectors from UI implementation - Timeout configuration in \`beforeEach\` hooks - Independent test cases with proper setup - Meaningful assertions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
