Lee-W commented on code in PR #59339:
URL: https://github.com/apache/airflow/pull/59339#discussion_r2639136257
##########
airflow-core/src/airflow/models/connection.py:
##########
@@ -330,15 +334,22 @@ def get_uri(self) -> str:
uri += host_block
if self.extra:
+ extra_dict = self.extra_dejson
+ can_flatten = True
+ for value in extra_dict.values():
+ if not isinstance(value, str):
+ can_flatten = False
+ break
+
try:
- query: str | None = urlencode(self.extra_dejson)
+ query = urlencode(extra_dict)
Review Comment:
would like to know why did we remove type annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
