jason810496 commented on code in PR #59339:
URL: https://github.com/apache/airflow/pull/59339#discussion_r2639805649
##########
airflow-core/src/airflow/models/connection.py:
##########
@@ -457,14 +470,14 @@ def get_extra_dejson(self, nested: bool = False) -> dict:
if self.extra:
try:
+ extra = json.loads(self.extra)
if nested:
- for key, value in json.loads(self.extra).items():
- extra[key] = value
+ for key, value in extra.items():
if isinstance(value, str):
- with suppress(JSONDecodeError):
+ try:
extra[key] = json.loads(value)
- else:
- extra = json.loads(self.extra)
+ except (JSONDecodeError, TypeError):
+ pass
Review Comment:
I think we could revert the change of `get_extra_dejson`, as current change
doesn't impact the behavior.Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
