Miretpl commented on code in PR #51792:
URL: https://github.com/apache/airflow/pull/51792#discussion_r2640590902
##########
chart/newsfragments/51792.significant.rst:
##########
@@ -0,0 +1,11 @@
+StatsD metrics aggregation now supports configurable TTL-enabled LRU cache to
prevent memory growth in long-running daemons.
Review Comment:
After changing in the values, you need to update the information in
newsfragment file
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -95,11 +95,22 @@ spec:
{{- if $containerLifecycleHooks }}
lifecycle: {{- tpl (toYaml $containerLifecycleHooks) . | nindent 12
}}
{{- end }}
- {{- if .Values.statsd.args }}
- args: {{ tpl (toYaml .Values.statsd.args) . | nindent 12 }}
- {{- else}}
args:
- - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
+ {{- if .Values.statsd.cache.size }}
+ - "--statsd.cache-size={{ .Values.statsd.cache.size }}"
+ {{- end }}
+ {{- if .Values.statsd.cache.type }}
+ - "--statsd.cache-type={{ .Values.statsd.cache.type }}"
+ {{- end }}
+ {{- if .Values.statsd.cache.ttl }}
+ - "--ttl={{ .Values.statsd.cache.ttl }}"
+ {{- end }}
+ {{- if .Values.statsd.args }}
+ {{- range $arg := .Values.statsd.args }}
+ - {{ $arg | quote }}
+ {{- end }}
Review Comment:
Maybe inside of `statsd.cache.enabled` flag 🤔, but I don't have a strong
opinion about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
