Dev-iL opened a new pull request, #59741:
URL: https://github.com/apache/airflow/pull/59741
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
related: #59218 #59739
## Description
This PR fixes a schema inconsistency that occurs on MySQL after running
database migrations.
## Problem
The `test_database_schema_and_sqlalchemy_model_are_in_sync` test fails on
MySQL with:
```none
Diff: [('modify_nullable', None, 'log', 'event', {'existing_type':
VARCHAR(collation='utf8mb4_unicode_ci', length=60), 'existing_server_default':
False, 'existing_comment': None}, True, False)]
```
The SQLAlchemy model defines `event: Mapped[str]` (non-nullable), but after
migration 0010 runs on MySQL, the column remains `nullable=True`.
## Root Cause
Migration 0010 increases the `event` column length from 30 to 60 characters
using `batch_alter_table`. However, on MySQL with SQLAlchemy 2.0, this
operation doesn't preserve or update the nullability constraint. The original
column was created as `nullable=True` in the squashed migration, and simply
changing the length doesn't align it with the ORM model's expectation of `NOT
NULL`.
## Solution
Use raw SQL `ALTER TABLE ... MODIFY COLUMN` for MySQL to explicitly change
the column length and set `NOT NULL`:
```sql
ALTER TABLE log MODIFY COLUMN event VARCHAR(60) NOT NULL
```
The fix also ensures any existing `NULL` values are handled before the
constraint is applied.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
