jscheffl commented on PR #59741: URL: https://github.com/apache/airflow/pull/59741#issuecomment-3686826689
Thanks for the fix and looking good - except a small "pitfall" that migth arise - you are altering the 2.9.0 migration means everybody migrating AFTER this PR landed in a release if migrating from before 2.9.0 will get this applied. If I earlier had migrated from 2.7.0 to 2.11.0 and then (later) will upgrade to 3.2.0 (assume this PR then is on main) will miss the `NOT NULL` change in the DB layout. Therefore to be in a consistent and clean state I'd suggest NOT to adjust the historic migration rule but adding a new one for everybody migrating to 3.2.0. Can you adjust this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
