potiuk commented on code in PR #59430: URL: https://github.com/apache/airflow/pull/59430#discussion_r2644095699
########## airflow-core/src/airflow/utils/static_checker.py: ########## @@ -0,0 +1,508 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import ast +from dataclasses import dataclass +from enum import Enum +from pathlib import Path + + +class StaticCheckerResult: Review Comment: Even here and module name -> I would say it's better if that whole PR focuses on "dag stability" or similar checks - rather than generic "static checks" -> yes it is done via static anaylysis of the AST, but there are so many different static checks that could even likely be done in different moments, with different switches and different "off/error/warning" values for the switches, that generically naming it "static checks" now is too early. I would say when we see the need for **third** such check we should see if we can implement some generic framework for static checks execution and error raising - but at this stage it's purely about "Dag stability". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
