potiuk commented on code in PR #59218:
URL: https://github.com/apache/airflow/pull/59218#discussion_r2647159403
##########
airflow-core/pyproject.toml:
##########
@@ -135,8 +135,8 @@ dependencies = [
"rich-argparse>=1.0.0",
"rich>=13.6.0",
"setproctitle>=1.3.3",
- # The issue tracking deprecations for sqlalchemy 2 is
https://github.com/apache/airflow/issues/28723
- "sqlalchemy[asyncio]>=1.4.49",
+ # SQLAlchemy >=2.0.36 fixes Python 3.13 TypingOnly import AssertionError
caused by new typing attributes (__static_attributes__, __firstlineno__)
+ "sqlalchemy[asyncio]>=2.0.36",
Review Comment:
Yes sqlqlchemy1 should be dropped. I think we should have a short DISCUSS
thread on it with pro/cons from people who have opinions and have a
vote/consensus on it
##########
airflow-core/pyproject.toml:
##########
@@ -135,8 +135,8 @@ dependencies = [
"rich-argparse>=1.0.0",
"rich>=13.6.0",
"setproctitle>=1.3.3",
- # The issue tracking deprecations for sqlalchemy 2 is
https://github.com/apache/airflow/issues/28723
- "sqlalchemy[asyncio]>=1.4.49",
+ # SQLAlchemy >=2.0.36 fixes Python 3.13 TypingOnly import AssertionError
caused by new typing attributes (__static_attributes__, __firstlineno__)
+ "sqlalchemy[asyncio]>=2.0.36",
Review Comment:
Yes sqlqlchemy1 should be dropped. I think we should have a short DISCUSS
thread on it with pro/cons from people who have opinions and have a
vote/consensus on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
