jscheffl commented on code in PR #59218:
URL: https://github.com/apache/airflow/pull/59218#discussion_r2647185128
##########
airflow-core/pyproject.toml:
##########
@@ -135,8 +135,8 @@ dependencies = [
"rich-argparse>=1.0.0",
"rich>=13.6.0",
"setproctitle>=1.3.3",
- # The issue tracking deprecations for sqlalchemy 2 is
https://github.com/apache/airflow/issues/28723
- "sqlalchemy[asyncio]>=1.4.49",
+ # SQLAlchemy >=2.0.36 fixes Python 3.13 TypingOnly import AssertionError
caused by new typing attributes (__static_attributes__, __firstlineno__)
+ "sqlalchemy[asyncio]>=2.0.36",
Review Comment:
Had also one thought in my mind - I think we are not affected but not sure
how much custom code could be affected relying on SQLalchemy? Airflow <=3.1 is
pinned to require SQLA<2 and if we merge it like this then Airflow >=3.2 will
require SQLA>=2.
In Pydantic we also had such breaking change, maybe there are more people
affected but there also we supported both v1+v2 in parallel for a while. (yes
and with the overhead having a CI test always running Pydantic v1 as well...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
