potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352704490
########## File path: airflow/plugins_manager.py ########## @@ -16,17 +15,18 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. - -import imp +"""Manages all plugins.""" +# noinspection PyDeprecation +import imp # pylint: disable=deprecated-module import inspect import os import re -from typing import Any, List +import sys +from typing import Any, Callable, List, Optional import pkg_resources from airflow import settings -from airflow.models.baseoperator import BaseOperatorLink Review comment: I am strongly agains using those kind of hacks - they are usually a symptom of an entangled architecture and not best choice of packages/files to split the code. It's like a "broken window" policy - once we let them in, then it's easier to add another exception. So I would like to avoid it at all cost. However in this case I have an idea that maybe we will be able to implement in the better version of plugins_manager unentangling. I will try it shortly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
